linux-kernel - Re: [PATCH 2/3] ads7846: always set last command to PWRDOWN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4YyOUsnFWzk//Dl@smile.fi.intel.com>
Date:   Tue, 29 Nov 2022 18:24:25 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Luca Ellero <l.ellero@...m.it>
Cc:     dmitry.torokhov@...il.com, daniel@...que.org,
        m.felsch@...gutronix.de, u.kleine-koenig@...gutronix.de,
        mkl@...gutronix.de, miquel.raynal@...tlin.com, imre.deak@...ia.com,
        luca.ellero@...ckedbrain.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ads7846: always set last command to PWRDOWN

On Tue, Nov 29, 2022 at 04:19:58PM +0100, Luca Ellero wrote:
> Controllers that report pressure (e.g. ADS7846) use 5 commands and the
> correct sequence is READ_X, READ_Y, READ_Z1, READ_Z2, PWRDOWN.
> 
> Controllers that don't report pressure (e.g. ADS7845/ADS7843) use only 3
> commands and the correct sequence should be READ_X, READ_Y, PWRDOWN. But
> the sequence sent was incorrect: READ_X, READ_Y, READ_Z1.

Besides the same comments as per patch 1...

> This patch fixes it.

"Fix this by..." (finish this with the correct wording).


-- 
With Best Regards,
Andy Shevchenko