linux-kernel - Re: [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe deferral log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f954e71b-043c-43bc-a692-530497de2d0b@gmail.com>
Date:   Tue, 29 Nov 2022 18:28:31 +0200
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Jayesh Choudhary <j-choudhary@...com>, vkoul@...nel.org
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe
 deferral log



On 28/11/2022 12:13, Jayesh Choudhary wrote:
> Change the log level from dev_err() to dev_dbg() for non-fatal probe
> deferral log for getting MSI domain.
> This makes the kernel log clean and we do not get recurring logs
> stating: "Failed to get MSI domain".

Or not print at all?

Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>

> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> ---
>   drivers/dma/ti/k3-udma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index ce8b80bb34d7..e540166cf4c7 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -5344,7 +5344,7 @@ static int udma_probe(struct platform_device *pdev)
>   	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
>   					    DOMAIN_BUS_TI_SCI_INTA_MSI);
>   	if (!dev->msi.domain) {
> -		dev_err(dev, "Failed to get MSI domain\n");
> +		dev_dbg(dev, "Failed to get MSI domain\n");
>   		return -EPROBE_DEFER;
>   	}
>   

-- 
Péter