linux-kernel - Re: [PATCH net-next v2] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2022 18:03:51 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Vincent MAILHOL <mailhol.vincent@...adoo.fr>
Cc:     Jiri Pirko <jiri@...nulli.us>, Jiri Pirko <jiri@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        linux-can <linux-can@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: devlink: add
 DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER

On 29.11.2022 18:28:44, Vincent MAILHOL wrote:
> On Tue. 29 Nov. 2022 at 17:33, Jiri Pirko <jiri@...nulli.us> wrote:
> > Tue, Nov 29, 2022 at 04:14:06AM CET, mailhol.vincent@...adoo.fr wrote:
> > >As discussed in [1], abbreviating the bootloader to "bl" might not be
> > >well understood. Instead, a bootloader technically being a firmware,
> > >name it "fw.bootloader".
> > >
> > >Add a new macro to devlink.h to formalize this new info attribute name
> > >and update the documentation.
> > >
> > >[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> > >
> > >Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > >Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> > >---
> > >* Changelog *
> > >
> > >v1 -> v2:
> > >
> > >  * update the documentation as well.
> > >  Link: https://lore.kernel.org/netdev/20221129020151.3842613-1-mailhol.vincent@wanadoo.fr/
> > >---
> > > Documentation/networking/devlink/devlink-info.rst | 5 +++++
> > > include/net/devlink.h                             | 2 ++
> > > 2 files changed, 7 insertions(+)
> > >
> > >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
> > >index 7572bf6de5c1..1242b0e6826b 100644
> > >--- a/Documentation/networking/devlink/devlink-info.rst
> > >+++ b/Documentation/networking/devlink/devlink-info.rst
> > >@@ -198,6 +198,11 @@ fw.bundle_id
> > >
> > > Unique identifier of the entire firmware bundle.
> > >
> > >+fw.bootloader
> > >+-------------
> > >+
> > >+Version of the bootloader.
> > >+
> > > Future work
> > > ===========
> > >
> > >diff --git a/include/net/devlink.h b/include/net/devlink.h
> > >index 074a79b8933f..2f552b90b5c6 100644
> > >--- a/include/net/devlink.h
> > >+++ b/include/net/devlink.h
> > >@@ -621,6 +621,8 @@ enum devlink_param_generic_id {
> > > #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE  "fw.roce"
> > > /* Firmware bundle identifier */
> > > #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID     "fw.bundle_id"
> > >+/* Bootloader */
> > >+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER    "fw.bootloader"
> >
> > You add it and don't use it. You should add only what you use.
> 
> I will use it in this series for the linux-can tree:
> https://lore.kernel.org/netdev/20221126162211.93322-4-mailhol.vincent@wanadoo.fr/
> 
> If it is a problem to send this as a standalone patch, I will then
> just add it to my series and have the patch go through the linux-can
> tree.

As you have the Ok from Greg, include this in you v5 series.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)