[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221130181536.GA2553507-robh@kernel.org>
Date: Wed, 30 Nov 2022 12:15:36 -0600
From: Rob Herring <robh@...nel.org>
To: Tao Zhang <quic_taozha@...cinc.com>
Cc: Mathieu Poirier <mathieu.poirier@...aro.org>,
Suzuki K Poulose <suzuki.poulose@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Konrad Dybcio <konradybcio@...il.com>,
Mike Leach <mike.leach@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jinlong Mao <quic_jinlmao@...cinc.com>,
Leo Yan <leo.yan@...aro.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
Tingwei Zhang <quic_tingweiz@...cinc.com>,
Yuanfang Zhang <quic_yuanfang@...cinc.com>,
Trilok Soni <quic_tsoni@...cinc.com>,
Hao Zhang <quic_hazha@...cinc.com>,
linux-arm-msm@...r.kernel.org, bjorn.andersson@...aro.org
Subject: Re: [PATCH v1 1/9] dt-bindings: arm: Add support for DSB element
On Mon, Nov 21, 2022 at 04:21:05PM +0800, Tao Zhang wrote:
> Add property "qcom,dsb-elem-size" to support DSB(Discrete Single
> Bit) element for TPDA. Specifies the DSB element size supported
> by each monitor connected to the aggregator on each port. Should
> be specified in pairs (port, dsb element size).
>
> Signed-off-by: Tao Zhang <quic_taozha@...cinc.com>
> ---
> Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> index c46ddea..e3b58b5 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> @@ -58,6 +58,13 @@ properties:
> minItems: 1
> maxItems: 2
>
> + qcom,dsb-elem-size:
> + description: |
> + Specifies the DSB element size supported by each monitor
> + connected to the aggregator on each port. Should be specified
> + in pairs (port, dsb element size).
Please define DSB somewhere here and not just the commit msg.
> + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +
> clocks:
> maxItems: 1
>
> @@ -100,6 +107,8 @@ examples:
> compatible = "qcom,coresight-tpda", "arm,primecell";
> reg = <0x6004000 0x1000>;
>
> + qcom,dsb-elem-size = <0 32>;
> +
> clocks = <&aoss_qmp>;
> clock-names = "apb_pclk";
>
> --
> 2.7.4
>
>
Powered by blists - more mailing lists