linux-kernel - Re: [PATCH] dt-bindings: leds: Mark label property as deprecated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221130191905.GA2631320-robh@kernel.org>
Date:   Wed, 30 Nov 2022 13:19:05 -0600
From:   Rob Herring <robh@...nel.org>
To:     Marek Vasut <marex@...x.de>
Cc:     Pavel Machek <pavel@....cz>,
        Christoph Niedermaier <cniedermaier@...electronics.com>,
        linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        kernel@...electronics.com, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Mark label property as deprecated

On Fri, Nov 25, 2022 at 10:26:30PM +0100, Marek Vasut wrote:
> On 11/22/22 13:23, Pavel Machek wrote:
> > Hi!
> 
> Hi,
> 
> > > Mark the label property as deprecated as it is mentioned
> > > in the description.
> > 
> > Lets do it the other way around. Functions (etc) don't really provide
> > good enough description of LED, and label is still needed.
> 
> Can you please provide a clear explanation which property or approach is the
> correct one for new DTs ?
> 
> So far, the documentation states that "label" is deprecated, and users
> should replace it with "function" and "color".

'function' is what activity/operation the LED is associated with. It is 
a fixed set of strings which s/w may use. It is a replacement for 
'linux,default-trigger'.

'label' is what is printed next to the LED for a human to read. 'label' 
can be anything and the OS shouldn't care what it is.


They serve 2 different purposes.

Rob