[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=VSLz6TLgdvzqdqi04C48gmqyRxVOtzWEdFmKQy9NuAOQ@mail.gmail.com>
Date: Wed, 30 Nov 2022 13:19:29 -0800
From: Doug Anderson <dianders@...omium.org>
To: Owen Yang <ecs.taipeikernel@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Harvey <hunge@...gle.com>,
Bob Moragues <moragues@...gle.com>,
Stephen Boyd <swboyd@...omium.org>,
Gavin Lee <gavin.lee@....com.tw>,
Matthias Kaehlcke <mka@...gle.com>,
Abner Yen <abner.yen@....com.tw>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v10 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie
Hi,
On Tue, Nov 29, 2022 at 10:30 PM Owen Yang <ecs.taipeikernel@...il.com> wrote:
>
> +&pm8350c_pwm_backlight{
> + pwms = <&pm8350c_pwm 3 200000>;
> +};
This is in the right location now, but previously I mentioned that it
would be nice to have a comment explaining what you're doing. In other
words, I wish the above was something like:
&pm8350c_pwm_backlight{
/* Set the PWM period to 200 microseconds (5kHz duty cycle)
pwms = <&pm8350c_pwm 3 200000>;
};
If you spin a v11 with that change feel free to add my Reviewed-by tag.
-Doug
Powered by blists - more mailing lists