[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4fMyEo0dxPl/Kt1@slm.duckdns.org>
Date: Wed, 30 Nov 2022 11:36:08 -1000
From: Tejun Heo <tj@...nel.org>
To: Kemeng Shi <shikemeng@...wei.com>
Cc: josef@...icpanda.com, axboe@...nel.dk, cgroups@...r.kernel.org,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/10] blk-throttle: avoid dead code in
throtl_hierarchy_can_upgrade
On Tue, Nov 29, 2022 at 11:01:47AM +0800, Kemeng Shi wrote:
> Function throtl_hierarchy_can_upgrade will always return from while loop,
> so the return outside while loop is never reached. Break the loop when
> we traverse to root as throtl_hierarchy_can_downgrade do to avoid dead
> code.
I don't know why this is an improvement.
--
tejun
Powered by blists - more mailing lists