linux-kernel - Re: next-20221122: tinyconfig: ppc n s390: kernel/printk/printk.c:95:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221130215917.GY4001@paulmck-ThinkPad-P17-Gen-1>
Date:   Wed, 30 Nov 2022 13:59:17 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Petr Mladek <pmladek@...e.com>
Cc:     John Ogness <john.ogness@...utronix.de>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: next-20221122: tinyconfig: ppc n s390:
 kernel/printk/printk.c:95:1: error: type specifier missing, defaults to
 'int'; ISO C99 and later do not support implicit int
 [-Werror,-Wimplicit-int]

On Wed, Nov 30, 2022 at 11:37:16AM +0100, Petr Mladek wrote:
> On Wed 2022-11-30 09:59:46, John Ogness wrote:
> > Hi Paul,
> > 
> > On 2022-11-29, "Paul E. McKenney" <paulmck@...nel.org> wrote:
> > > And this seems have avoided breaking things, so I moved it on top of
> > > the earlier srcunmisafe.2022.11.09a stack with a new
> > > srcunmisafe.2022.11.29a branch name.
> > >
> > > If you need me to, I can push this into the upcoming merge window.  Or
> > > you could rebase on top of it, so that when the printk() series goes
> > > in, this commit will come along for the ride.
> > 
> > It would be great if the series could land in linux-next, to give any
> > other issues with the series a chance to show up.
> > 
> > Also, since the series is relatively significant, it would probably be
> > better if it was pushed into the 6.2 merge window by you. Petr will need
> > to make sure the printk series for the merge window is properly rebased
> > for it.
> 
> I have rebased the branch rework/console-list-lock in printk/linux.git
> on top of the new srcunmisafe.2022.11.29a.

Very good, thank you!

> It means that the changes will be part of the pull request from
> the printk tree.
> 
> Anyway, it would be nice if Paul adds this branch into the pull request
> for RCU tree as well. Then we could both send pull request soon
> and it will not matter which one will be handled first.
> 
> Does it make any sense, please?
> 
> I have never done it this way before. The motivation is to allow
> sending both pull requests soon. Linus likes early pull requests.
> The fact that it will go also via RCU tree would make it clear
> that Paul wanted to send it in this form. Or is it a bad idea?
> Do I over-complicate it?

All fair points.

I have srcunmisafe.2022.11.29a merged into -rcu immediately following
my RCU merge commit for the upcoming merge window.  My current rcu/next
branch includes it.

So if there are no mandatory-SRCU explosions in -next by Sunday December
4th, I will send Linus this commit in the merge window that is currently
slated to open the week of December 12th:

ec69c6900127 ("srcunmisafe.2022.11.29a: Make SRCU mandatory.")

As the title suggests, this includes the desired commit.

If there are explosions, well, we will deal with them and see where
we go from there.  My fallback commit would be this guy:

87492c06e68d ("Merge branches 'doc.2022.10.20a', 'fixes.2022.10.21a', 'lazy.2022.11.30a', 'srcunmisafe.2022.11.09a', 'torture.2022.10.18c' and 'torturescript.2022.10.20a' into HEAD")

This excludes that commit.  But hopefully there will be no explosions
that cannot be taken care of quickly.

Does that work for you?

							Thanx, Paul