linux-kernel - Re: [PATCH rcu 14/16] rxrpc: Use call_rcu_hurry() instead of call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2022 17:06:33 -0500
From:   Joel Fernandes <joel@...lfernandes.org>
To:     paulmck@...nel.org
Cc:     David Howells <dhowells@...hat.com>, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...a.com,
        rostedt@...dmis.org, Marc Dionne <marc.dionne@...istor.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-afs@...ts.infradead.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH rcu 14/16] rxrpc: Use call_rcu_hurry() instead of call_rcu()



> On Nov 30, 2022, at 4:43 PM, Paul E. McKenney <paulmck@...nel.org> wrote:
> 
> On Wed, Nov 30, 2022 at 02:20:52PM -0500, Joel Fernandes wrote:
>> 
>> 
>>>> On Nov 30, 2022, at 2:09 PM, David Howells <dhowells@...hat.com> wrote:
>>> 
>>> Note that this conflicts with my patch:
>> 
>> Oh.  I don’t see any review or Ack tags on it. Is it still under review?
> 
> So what I have done is to drop this patch from the series, but to also
> preserve it for posterity at -rcu branch lazy-obsolete.2022.11.30a.
> 
> It looks like that wakeup is still delayed, but I could easily be
> missing something.
> 
> Joel, could you please test the effects of having the current lazy branch,
> but also David Howells's patch?  That way, if there is an issue, we can
> work it sooner rather than later, and if it all works fine, we can stop
> worrying about it.  ;-)

Sure, I will kick off the failing test and see if it passes with Davids patch. Will let you know.

Thanks,

 - Joel


>                            Thanx, Paul
> 
>> Thanks,
>> 
>> - Joel
>> 
>> 
>> 
>>> 
>>>   rxrpc: Don't hold a ref for connection workqueue
>>>   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-next&id=450b00011290660127c2d76f5c5ed264126eb229
>>> 
>>> which should render it unnecessary.  It's a little ahead of yours in the
>>> net-next queue, if that means anything.
>>> 
>>> David
>>>