linux-kernel - Re: [PATCH] input/misc: wistron

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4fkNy9URvaW+AtN@google.com>
Date:   Wed, 30 Nov 2022 15:16:07 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Johannes Berg <johannes.berg@...el.com>,
        Richard Weinberger <richard@....at>,
        Miloslav Trmac <mitr@...ny.cz>, linux-input@...r.kernel.org,
        linux-um@...ts.infradead.org
Subject: Re: [PATCH] input/misc: wistron_btns: disable on UML

On Wed, Nov 30, 2022 at 08:16:04AM -0800, Randy Dunlap wrote:
> The wistron_btns driver calls rtc_cmos_read(), which isn't
> available with UML builds, so disable this driver on UML.
> 
> Prevents this build error:
> 
> ld: drivers/input/misc/wistron_btns.o: in function `poll_bios':
> wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read'
> 
> Fixes: 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Miloslav Trmac <mitr@...ny.cz>
> Cc: linux-input@...r.kernel.org
> Cc: linux-um@...ts.infradead.org

Applied, thank you.

-- 
Dmitry