[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4cAZ8ZqnRvR350Z@hovoldconsulting.com>
Date: Wed, 30 Nov 2022 08:04:07 +0100
From: Johan Hovold <johan@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: qcom-ep: Fix PERST register description
On Tue, Oct 18, 2022 at 11:31:15AM +0200, Johan Hovold wrote:
> The 'qcom,perst-regs' property holds a single phandle array with the
> phandle of the TCSR syscon and offsets of the two PERST registers, but
> the current schema does not capture this.
>
> Update the binding to describe the single phandle array and its three
> elements.
>
> Fixes: 31c9ef002580 ("dt-bindings: PCI: Add Qualcomm PCIe Endpoint controller")
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
> .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> index 977c976ea799..7574291646ad 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -42,13 +42,13 @@ properties:
> maxItems: 8
>
> qcom,perst-regs:
> - description: Reference to a syscon representing TCSR followed by the two
> - offsets within syscon for Perst enable and Perst separation
> - enable registers
> + description: PERST TCSR registers
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> items:
> - minItems: 3
> - maxItems: 3
> + - items:
> + - description: phandle of TCSR syscon
> + - description: offset of PERST Enable register
> + - description: offset of PERST Separation Enable register
>
> interrupts:
> items:
Lorenzo, it seems this one has not yet been picked up so sending a
reminder.
Johan
Powered by blists - more mailing lists