linux-kernel - Re: [PATCH v2] iommu/vt-d: Add a fix for devices need extra dtlb flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221129163412.15da3081@jacob-builder>
Date:   Tue, 29 Nov 2022 16:34:12 -0800
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     Baolu Lu <baolu.lu@...ux.intel.com>
Cc:     iommu@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>,
        Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Robin Murphy <robin.murphy@....com>,
        Will Deacon <will@...nel.org>, Yi Liu <yi.l.liu@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        Raj Ashok <ashok.raj@...el.com>,
        Yuzhang Luo <yuzhang.luo@...el.com>,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v2] iommu/vt-d: Add a fix for devices need extra dtlb
 flush

Hi Baolu,

On Wed, 30 Nov 2022 08:10:55 +0800, Baolu Lu <baolu.lu@...ux.intel.com>
wrote:

> > --- a/drivers/iommu/intel/iommu.c
> > +++ b/drivers/iommu/intel/iommu.c
> > @@ -1396,6 +1396,23 @@ static void domain_update_iotlb(struct
> > dmar_domain *domain) spin_unlock_irqrestore(&domain->lock, flags);
> >   }
> >   
> > +/*
> > + * Impacted QAT device IDs ranging from 0x4940 to 0x4943.
> > + * This quirk is exempted from risky_device() check because it applies
> > only
> > + * to the built-in QAT devices.
> > + */  
> 
> How about adding:
> 
> "This quirk is exempted from risky_device() check because it doesn't
> effectively grant additional privileges."
sounds good.

Thanks,

Jacob