[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqLpN+CORV8ys3yijB=qHqKF1LjrF=Rrb6AkOEuKc608YA@mail.gmail.com>
Date: Tue, 29 Nov 2022 18:35:29 -0600
From: Rob Herring <robh+dt@...nel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
pavel@....cz, Geert Uytterhoeven <geert+renesas@...der.be>
Cc: jacek.anaszewski@...il.com, krzysztof.kozlowski+dt@...aro.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, thunder.leizhen@...wei.com,
festevam@...il.com
Subject: Re: [PATCH v4] dt-bindings: leds: Document commonly used LED triggers
On Tue, Nov 29, 2022 at 11:49 AM Manivannan Sadhasivam
<manivannan.sadhasivam@...aro.org> wrote:
>
> Document the commonly used LED triggers by the SoCs. Not all triggers
> are documented as some of them are very application specific. Most of the
> triggers documented here are currently used in devicetrees of many SoCs.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>
> Changes in v4:
>
> * Removed the sorting of triggers
> * Removed the "items" as they were not needed
> * Reworded the description
> * Dropped Zhen Lei's tested-by tag as the patch has changed
> * Added kbd-capslock trigger
>
> Changes in v3:
>
> * Rebased on top of v6.1-rc1
> * Added WLAN Rx trigger
> * Added tested tag from Zhen Lei
>
> Changes in v2:
>
> * Added more triggers, fixed the regex
> * Sorted triggers in ascending order
>
> .../devicetree/bindings/leds/common.yaml | 40 ++++++++++++++++++-
> 1 file changed, 38 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 3c14a98430e1..68da651f29a8 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -98,8 +98,44 @@ properties:
> # LED alters the brightness for the specified duration with one software
> # timer (requires "led-pattern" property)
> - pattern
> - # LED is triggered by SD/MMC activity
> - - pattern: "^mmc[0-9]+$"
> + # LED indicates mic mute state
> + - audio-micmute
> + # LED indicates audio mute state
> + - audio-mute
> + # LED indicates bluetooth power state
> + - bluetooth-power
> + # LED indicates activity of all CPUs
> + - cpu
> + # LED indicates disk read activity
> + - disk-read
> + # LED indicates disk write activity
> + - disk-write
> + # LED indicates camera flash state
> + - flash
> + # LED indicated keyboard capslock
> + - kbd-capslock
> + # LED indicates MTD memory activity
> + - mtd
> + # LED indicates NAND memory activity (deprecated),
> + # in new implementations use "mtd"
> + - nand-disk
> + # No trigger assigned to the LED. This is the default mode
> + # if trigger is absent
> + - none
> + # LED indicates camera torch state
> + - torch
> + # LED indicates USB gadget activity
> + - usb-gadget
> + # LED indicates USB host activity
> + - usb-host
> + # LED indicates [N]th MMC storage activity
> + - pattern: "^mmc[0-9]{1,2}$"
> + # LED indicates activity of [N]th CPU
> + - pattern: "^cpu[0-9]{1,2}$"
This will conflict with Pawel's tree because I already added this.
Mine covers 'cpu' and my 100 core system with 100 cpu leds. ;)
> + # LED indicates power status of [N]th Bluetooth HCI device
> + - pattern: "^hci[0-9]{1,2}-power$"
> + # LED indicates [N]th WLAN Tx/Rx activity
> + - pattern: "^phy[0-9]{1,2}(tx|rx)$"
And these are pending from Geert[1].
Rob
[1] https://lore.kernel.org/all/a85c256af01f64389a078c2b37c3b72a27d97536.1668005062.git.geert+renesas@glider.be/
Powered by blists - more mailing lists