lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Nov 2022 15:56:06 +0800 (CST) From: <zhang.songyi@....com.cn> To: <arnd@...db.de> Cc: <zhang.songyi@....com.cn>, <robert.jarzmik@...e.fr>, <lkundrak@...sk>, <linux-kernel@...r.kernel.org> Subject: [PATCH linux-next] pxa: Remove dev_err() after platform_get_irq() From: zhang songyi <zhang.songyi@....com.cn> There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. /drivers/soc/pxa/ssp.c:150:2-9: line 150 is redundant because platform_get_irq() already prints an error Signed-off-by: zhang songyi <zhang.songyi@....com.cn> --- drivers/soc/pxa/ssp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c index 93449fb3519e..7085901b4e4b 100644 --- a/drivers/soc/pxa/ssp.c +++ b/drivers/soc/pxa/ssp.c @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev) ssp->irq = platform_get_irq(pdev, 0); if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); return -ENODEV; } -- 2.15.2
Powered by blists - more mailing lists