[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221130080059.dwyscjvro6bcmfj3@shindev>
Date: Wed, 30 Nov 2022 08:00:59 +0000
From: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To: Chaitanya Kulkarni <kch@...dia.com>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"axboe@...nel.dk" <axboe@...nel.dk>,
"damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
"bvanassche@....org" <bvanassche@....org>,
"vincent.fu@...sung.com" <vincent.fu@...sung.com>
Subject: Re: [PATCH V4 2/8] null_blk: code cleaup
On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> Introduce and use two new macros for calculating the page index from
> given sector and index (offset) of the sector in the page.
> The newly added macros makes code easy to read with meaningful name and
> explanation comments attached to it.
>
> While at it adjust the code in the null_free_sector() to return early
> to get rid of the extra identation.
>
> Signed-off-by: Chaitanya Kulkarni <kch@...dia.com>
Looks good to me.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>
--
Shin'ichiro Kawasaki
Powered by blists - more mailing lists