linux-kernel - Re: [PATCH V4 6/8] null_blk: add param to set max disacrd sectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221130080742.tlr7nnxernioteps@shindev>
Date:   Wed, 30 Nov 2022 08:07:43 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Chaitanya Kulkarni <kch@...dia.com>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "vincent.fu@...sung.com" <vincent.fu@...sung.com>
Subject: Re: [PATCH V4 6/8] null_blk: add param to set max disacrd sectors

On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> Instead of hardcoding value for the maximum discard sector to
> UINT_MAX >> 9, allow user to set the value with newly added module
> parameter max_discard_sectors.
> 
> To retain the backward compatibility make set default value to
> UINT_MAX >> 9.
> 
> Signed-off-by: Chaitanya Kulkarni <kch@...dia.com>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>

-- 
Shin'ichiro Kawasaki