linux-kernel - Re: [PATCH] IB/hfi1: switch to netif_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y4cXAIzTsUVYvfg4@unreal>
Date:   Wed, 30 Nov 2022 10:40:32 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     cgel.zte@...il.com
Cc:     dennis.dalessandro@...nelisnetworks.com, jgg@...pe.ca,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yang Yang <yang.yang29@....com.cn>
Subject: Re: [PATCH] IB/hfi1: switch to netif_napi_add()

On Tue, Nov 29, 2022 at 10:25:01AM +0000, cgel.zte@...il.com wrote:
> From: Yang Yang <yang.yang29@....com.cn>
> 
> There is no need to use netif_napi_add_weight() when the weight argument
> is 64. See "net: drop the weight argument from netif_napi_add".
> 
> Signed-off-by: Yang Yang <yang.yang29@....com.cn>
> ---
>  drivers/infiniband/hw/hfi1/netdev_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please send this patch as plain-text with git send-email.
It wasn't recorded in https://lore.kernel.org/linux-rdma/

Thanks

> 
> diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> index 3dfa5aff2512..720d4c85c9c9 100644
> --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> @@ -216,7 +216,7 @@ static int hfi1_netdev_rxq_init(struct hfi1_netdev_rx *rx)
>  		 * right now.
>  		 */
>  		set_bit(NAPI_STATE_NO_BUSY_POLL, &rxq->napi.state);
> -		netif_napi_add_weight(dev, &rxq->napi, hfi1_netdev_rx_napi, 64);
> +		netif_napi_add(dev, &rxq->napi, hfi1_netdev_rx_napi);
>  		rc = msix_netdev_request_rcd_irq(rxq->rcd);
>  		if (rc)
>  			goto bail_context_irq_failure;
> -- 
> 2.25.1
>