Message-ID: <Y4crh0Ob3sz20s5T@google.com>
Date:   Wed, 30 Nov 2022 10:08:07 +0000
From:   Lee Jones <lee@...nel.org>
To:     Alexandre Mergnat <amergnat@...libre.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Fabien Parent <fabien.parent@...aro.org>,
        Tianping Fang <tianping.fang@...iatek.com>,
        Flora Fu <flora.fu@...iatek.com>,
        Chen Zhong <chen.zhong@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Pavel Machek <pavel@....cz>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-mediatek@...ts.infradead.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
        Mattijs Korpershoek <mkorpershoek@...libre.com>,
        linux-rtc@...r.kernel.org, linux-input@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Fabien Parent <fparent@...libre.com>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v7 4/8] dt-bindings: mfd: mediatek: Add bindings for
 MT6357 PMIC

On Tue, 29 Nov 2022, Alexandre Mergnat wrote:

> Currently, almost all MT63XX PMIC are documented mfd/mt6397.txt.
> Unfortunately, the PMICs haven't always similar HW sub-features.
> To have a better human readable schema, I chose to make one PMIC schema
> to match the exact HW capabilities instead of convert mt6397.txt to
> mediatek,mt63xx.yaml and put a bunch of properties behind
> "if contain ... then ..."
> 
> - add interrupt property
> - change property refs to match with new yaml documentation
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>

Acked-by: Lee Jones <lee@...nel.org>

> ---
>  .../devicetree/bindings/mfd/mediatek,mt6357.yaml   | 111 +++++++++++++++++++++
>  1 file changed, 111 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
> new file mode 100644
> index 000000000000..837a77013d57
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
> @@ -0,0 +1,111 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mediatek,mt6357.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6357 PMIC
> +
> +maintainers:
> +  - Flora Fu <flora.fu@...iatek.com>
> +  - Alexandre Mergnat <amergnat@...libre.com>
> +
> +description: |
> +  MT6357 is a power management system chip containing 5 buck
> +  converters and 29 LDOs. Supported features are audio codec,
> +  USB battery charging, fuel gauge, RTC
> +
> +  This is a multifunction device with the following sub modules:
> +  - Regulator
> +  - RTC
> +  - Keys
> +
> +  It is interfaced to host controller using SPI interface by a proprietary hardware
> +  called PMIC wrapper or pwrap. This MFD is a child device of pwrap.
> +  See the following for pwrap node definitions:
> +  Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +
> +properties:
> +  compatible:
> +    const: mediatek,mt6357
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  regulators:
> +    type: object
> +    $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml
> +    description:
> +      List of MT6357 BUCKs and LDOs regulators.
> +
> +  rtc:
> +    type: object
> +    $ref: /schemas/rtc/rtc.yaml#
> +    description:
> +      MT6357 Real Time Clock.
> +    properties:
> +      compatible:
> +        const: mediatek,mt6357-rtc
> +      start-year: true
> +    required:
> +      - compatible
> +
> +  keys:
> +    type: object
> +    $ref: /schemas/input/mediatek,pmic-keys.yaml
> +    description:
> +      MT6357 power and home keys.
> +
> +required:
> +  - compatible
> +  - regulators
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    pwrap {
> +        pmic {
> +            compatible = "mediatek,mt6357";
> +
> +            interrupt-parent = <&pio>;
> +            interrupts = <145 IRQ_TYPE_LEVEL_HIGH>;
> +            interrupt-controller;
> +            #interrupt-cells = <2>;
> +
> +            regulators {
> +                mt6357_vproc_reg: buck-vproc {
> +                    regulator-name = "vproc";
> +                    regulator-min-microvolt = <518750>;
> +                    regulator-max-microvolt = <1312500>;
> +                    regulator-ramp-delay = <6250>;
> +                    regulator-enable-ramp-delay = <220>;
> +                    regulator-always-on;
> +                };
> +
> +                // ...
> +
> +                mt6357_vusb33_reg: ldo-vusb33 {
> +                    regulator-name = "vusb33";
> +                    regulator-min-microvolt = <3000000>;
> +                    regulator-max-microvolt = <3100000>;
> +                    regulator-enable-ramp-delay = <264>;
> +                };
> +            };
> +
> +            rtc {
> +                compatible = "mediatek,mt6357-rtc";
> +            };
> +
> +            keys {
> +                compatible = "mediatek,mt6357-keys";
> +            };
> +        };
> +    };
> 

-- 
Lee Jones [李琼斯]

Powered by blists - more mailing lists