lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y4c2hWw6kywpChb3@smile.fi.intel.com>
Date:   Wed, 30 Nov 2022 12:55:01 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Gerald Loacker <gerald.loacker@...fvision.net>
Cc:     linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jakob Hauser <jahau@...ketmail.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Michael Riesch <michael.riesch@...fvision.net>
Subject: Re: [PATCH v4 3/3] iio: magnetometer: add ti tmag5273 driver

On Wed, Nov 30, 2022 at 10:04:41AM +0100, Gerald Loacker wrote:
> Am 29.11.2022 um 17:37 schrieb Andy Shevchenko:
> > On Tue, Nov 29, 2022 at 07:45:40AM +0100, Gerald Loacker wrote:

...

> >> +		snprintf(data->name, sizeof(data->name), "tmag5273x%1u", data->version);
> > 
> > Thinking more about this format, perhaps
> > 
> > 		snprintf(data->name, sizeof(data->name), "tmag5273x-v%1u", data->version);
> > 
> > ?
> 
> I'd prefer to keep this as it's related to the orderable part number,
> e.g. TMAG5273A1 / TMAG5273A2.

I see, can you add a comment above to clarify the chosen format?

-- 
With Best Regards,
Andy Shevchenko


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ