linux-kernel - Re: [PATCH 1/2] interconnect: qcom: Add SM6115 interconnect provider driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH=2Nty3zM+arxJaeZ7YWh6fyuE8jWnV9rpKjuNxDS2zUnqNVw@mail.gmail.com>
Date:   Wed, 30 Nov 2022 17:10:42 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        agross@...nel.org, bhupesh.linux@...il.com,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        krzysztof.kozlowski@...aro.org, djakov@...nel.org,
        a39.skl@...il.com, andersson@...nel.org
Subject: Re: [PATCH 1/2] interconnect: qcom: Add SM6115 interconnect provider driver

Hi Konrad,

On Wed, 30 Nov 2022 at 16:37, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
>
>
> On 30.11.2022 11:38, Bhupesh Sharma wrote:
> > Add driver for the Qualcomm interconnect buses found in SM6115 based
> > platforms. The topology consists of several NoCs that are controlled by
> > a remote processor that collects the aggregated bandwidth for each
> > master-slave pairs.
> >
> > Cc: Bjorn Andersson <andersson@...nel.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> > ---
>
> [...]
>
> > +MODULE_DEVICE_TABLE(of, sm6115_qnoc_of_match);
> > +
> > +static struct platform_driver sm6115_qnoc_driver = {
> > +     .probe = qnoc_probe,
> > +     .remove = qnoc_remove,
> > +     .driver = {
> > +             .name = "qnoc-sm6115",
> > +             .of_match_table = sm6115_qnoc_of_match,
> No .sync_state?

Oops. Will add it in v2,

> > +     },
> > +};
> > +module_platform_driver(sm6115_qnoc_driver);
> > +
> > +MODULE_DESCRIPTION("Qualcomm SM6115 NoC driver");
> > +MODULE_LICENSE("GPL v2");
> "GPL", checkpatch should have pointed that out.

Sure, I will fix this in v2.

Thanks,
Bhupesh