linux-kernel - Re: [PATCH 2/2] dt-bindings: interconnect: Add SM6115 DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH=2NtzOdYS1K4Qt6nje=Yo1g5mxp1p6k6MMisAyV-wUnZWkPA@mail.gmail.com>
Date:   Wed, 30 Nov 2022 17:13:58 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        agross@...nel.org, bhupesh.linux@...il.com,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        djakov@...nel.org, konrad.dybcio@...aro.org, a39.skl@...il.com,
        andersson@...nel.org
Subject: Re: [PATCH 2/2] dt-bindings: interconnect: Add SM6115 DT bindings

Hi Krzysztof,

Thanks for your review.

On Wed, 30 Nov 2022 at 17:11, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 30/11/2022 11:38, Bhupesh Sharma wrote:
> > The Qualcomm SM6115 SoC has several bus fabrics that could be
> > controlled and tuned dynamically according to the bandwidth demand.
> >
> > Add the support for the same.
> >
> > Cc: Bjorn Andersson <andersson@...nel.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> > ---
>
> Thank you for your patch. There is something to discuss/improve.
>
> We could create common properties for these bindings, but it's fine now.
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/qcom,rpmcc.h>
> > +
> > +    snoc: interconnect@...0000 {
> > +        compatible = "qcom,sm6115-snoc";
> > +        reg = <0x01880000 0x60200>;
> > +        #interconnect-cells = <1>;
> > +        clock-names = "bus", "bus_a";
> > +        clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> > +                 <&rpmcc RPM_SMD_SNOC_A_CLK>;
> > +
> > +        clk_virt: interconnect-clk {
> > +            compatible = "qcom,sm6115-clk-virt";
> > +            #interconnect-cells = <1>;
> > +            clock-names = "bus", "bus_a";
> > +            clocks = <&rpmcc RPM_SMD_QUP_CLK>,
> > +                     <&rpmcc RPM_SMD_QUP_A_CLK>;
> > +        };
> > +
> > +        mmnrt_virt: interconnect-mmnrt {
> > +            compatible = "qcom,sm6115-mmnrt-virt";
> > +            #interconnect-cells = <1>;
> > +            clock-names = "bus", "bus_a";
> > +            clocks = <&rpmcc RPM_SMD_MMNRT_CLK>,
> > +                     <&rpmcc RPM_SMD_MMNRT_A_CLK>;
> > +        };
> > +
> > +        mmrt_virt: interconnect-mmrt {
> > +            compatible = "qcom,sm6115-mmrt-virt";
> > +            #interconnect-cells = <1>;
> > +            clock-names = "bus", "bus_a";
> > +            clocks = <&rpmcc RPM_SMD_MMRT_CLK>,
> > +                     <&rpmcc RPM_SMD_MMRT_A_CLK>;
> > +        };
>
> Drop last two nodes - they are the same as first.
>
> > +    };
> > +
> > +    cnoc: interconnect@...0000 {
> > +        compatible = "qcom,sm6115-cnoc";
> > +        reg = <0x01900000 0x8200>;
> > +        #interconnect-cells = <1>;
> > +        clock-names = "bus", "bus_a";
> > +        clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
> > +                 <&rpmcc RPM_SMD_CNOC_A_CLK>;
> > +    };
> > +
> > +    bimc: interconnect@...0000 {
> > +        compatible = "qcom,sm6115-bimc";
> > +        reg = <0x04480000 0x80000>;
> > +        #interconnect-cells = <1>;
> > +        clock-names = "bus", "bus_a";
> > +        clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> > +                 <&rpmcc RPM_SMD_BIMC_A_CLK>;
> > +    };
>
> Drop these two as well, they do not bring anything new here.

Ack for both the suggestions. I will fix and send a v2 shortly.

Regards,
Bhupesh