linux-kernel - Re: [PATCH V2] dt-bindings: mmc: Remove comment on wakeup-source property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFoMQH=XnF=v9nCg0=xws985nXCDNygCLKkuY82Nt4VLyg@mail.gmail.com>
Date:   Wed, 30 Nov 2022 12:57:15 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Christoph Niedermaier <cniedermaier@...electronics.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marek Vasut <marex@...x.de>,
        kernel <kernel@...electronics.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH V2] dt-bindings: mmc: Remove comment on wakeup-source property

On Wed, 30 Nov 2022 at 12:55, Christoph Niedermaier
<cniedermaier@...electronics.com> wrote:
>
> From: Ulf Hansson [mailto:ulf.hansson@...aro.org]
> Sent: Wednesday, November 30, 2022 12:40 PM
> > On Wed, 30 Nov 2022 at 11:20, Christoph Niedermaier<cniedermaier@...electronics.com> wrote:
> >>
> >> The current comment on wakeup-source is a little confusing because
> >> the word deprecated can be interpreted at first glance to mean that
> >> wakeup-source is deprecated. Also mentioning the obsolete property
> >> confuses more than it helps. Therefore, the comment should be removed
> >> completely because the enable-sdio-wakeup property is not used in
> >> any current DTs.
> >>
> >> Signed-off-by: Christoph Niedermaier <cniedermaier@...electronics.com>
> >> ---
> >> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> >> Cc: Rob Herring <robh+dt@...nel.org>
> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> >> Cc: Marek Vasut <marex@...x.de>
> >> Cc: kernel@...electronics.com
> >> Cc: linux-mmc@...r.kernel.org
> >> Cc: devicetree@...r.kernel.org
> >> To: linux-kernel@...r.kernel.org
> >> ---
> >> V2: - Instead of changing the comment, remove it
> >> ---
> >>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> >> index 802e3ca8be4d..e82c00368088 100644
> >> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> >> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> >> @@ -293,7 +293,6 @@ properties:
> >>      description:
> >>        SDIO only. Preserves card power during a suspend/resume cycle.
> >>
> >> -  # Deprecated: enable-sdio-wakeup
> >>    wakeup-source:
> >>      $ref: /schemas/types.yaml#/definitions/flag
> >>      description:
> >
> > This looks good to me!
> >
> > However, let's also drop the reference to the property from
> > Documentation/devicetree/bindings/power/wakeup-source.txt.
>
> Should I include this in a version 3 or should I send a separate patch?

Please add it in v3, so we can remove the confusing things altogether.

Kind regards
Uffe