linux-kernel - Re: [RFC v1] hack: suspend: usb: option: add reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f220084-6f2c-f7d2-7bb6-3051c28c019c@suse.com>
Date:   Wed, 30 Nov 2022 15:04:28 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>, johan@...nel.org,
        gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, phone-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC v1] hack: suspend: usb: option: add reset_resume callback



On 30.11.22 13:15, Martin Kepplinger wrote:
> Currently to be the same as resume(). This will just avoid re-enumeration
> of the modem device on every system resume.
> 
> This exists only because the usb core will re-enumerate *any* device
> whos' driver doesn't have reset_resume() implemented. A call trace:

Hi,

this is deeply problematic. Strictly speaking it introduces a bug.
By implementing reset_resume() you are telling the rest of the system
that all settings have survived the hibernation. That is likely wrong in
your case.

	Regards
		Oliver