linux-kernel - Re: [PATCH linux-next] recordmcount: use "!P" instead of "P == 0"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221130090530.3e7ec88e@gandalf.local.home>
Date:   Wed, 30 Nov 2022 09:05:30 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     <zhang.songyi@....com.cn>
Cc:     <zhangqing@...ngson.cn>, <chenhuacai@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH linux-next] recordmcount: use "!P" instead of "P == 0"

On Wed, 30 Nov 2022 15:47:35 +0800 (CST)
<zhang.songyi@....com.cn> wrote:

> From: zhang songyi <zhang.songyi@....com.cn>
> 
> comparing pointer to 0, use !P instead of it.

Both are correct. No need for useless churn like this.

-- Steve

> 
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>  scripts/recordmcount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index cce12e1971d8..8d01decd12e9 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -139,7 +139,7 @@ static ssize_t uwrite(void const *const buf, size_t const count)
>  static void * umalloc(size_t size)
>  {
>         void *const addr = malloc(size);
> -       if (addr == 0) {
> +       if (!addr) {
>                 fprintf(stderr, "malloc failed: %zu bytes\n", size);
>                 file_append_cleanup();
>                 mmap_cleanup();
> --
> 2.15.2