[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221129183102.1983375c@kernel.org>
Date: Tue, 29 Nov 2022 18:31:02 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
Cc: linux-can@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
netdev@...r.kernel.org, linux-usb@...r.kernel.org,
Saeed Mahameed <saeed@...nel.org>,
Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...dia.com>,
Lukas Magel <lukas.magel@...teo.net>
Subject: Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version
through ethtool
On Wed, 30 Nov 2022 02:12:27 +0900 Vincent MAILHOL wrote:
> I was not aware of this one. Thank you for pointing this out.
> If I correctly understand, devlink_compat_running_version() is
> supposed to allow ethtool to retrieve the firmware version from
> devlink, right?
Yes.
> Currently it does not work. I guess it is because I am not using
> SET_NETDEV_DEVLINK_PORT()? I initially thought that this was optional.
It's optional but breaks the linking hence the fallback can't kick in.
I guess "optional-ity" is a spectrum :)
> I will continue to investigate and see if it is possible to completely
> remove the .get_drvinfo() callback.
Powered by blists - more mailing lists