[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87a648tq8f.ffs@tglx>
Date: Wed, 30 Nov 2022 16:29:52 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Samuel Holland <samuel@...lland.org>,
Marc Zyngier <maz@...nel.org>,
Palmer Dabbelt <palmer@...belt.com>
Cc: linux-riscv@...ts.infradead.org,
Samuel Holland <samuel@...lland.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] genirq: Simplify cond_unmask_eoi_irq()
On Wed, Nov 30 2022 at 15:48, Thomas Gleixner wrote:
> On Sat, Nov 26 2022 at 17:41, Samuel Holland wrote:
>> + (desc->istate & IRQS_ONESHOT) && !desc->threads_oneshot)
>> unmask_irq(desc);
>
> This breaks the mask logic of handle_fasteoi_mask_irq() for an interrupt
> which does not have IRQS_ONESHOT set.
Ignore this one. That handler is broken by design.
Powered by blists - more mailing lists