linux-kernel - Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4d+KcqQQzKBpo8z@lunn.ch>
Date:   Wed, 30 Nov 2022 17:00:41 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jerry.Ray@...rochip.com
Cc:     olteanv@...il.com, f.fainelli@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats

On Wed, Nov 30, 2022 at 03:57:35PM +0000, Jerry.Ray@...rochip.com wrote:
> >>  static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
> >>                                     uint64_t *data)
> >>  {
> >>       struct lan9303 *chip = ds->priv;
> >> -     unsigned int u;
> >> +     unsigned int i, u;
> >>
> >>       for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
> >>               u32 reg;
> >>               int ret;
> >>
> >> -             ret = lan9303_read_switch_port(
> >> -                     chip, port, lan9303_mib[u].offset, &reg);
> >> -
> >> +             /* Read Port-based MIB stats. */
> >> +             ret = lan9303_read_switch_port(chip, port,
> >> +                                            lan9303_mib[u].offset,
> >> +                                            &reg);
> >
> >Speaking of unrelated changes...
> >
> 
> Cleaning up a warning generated from checkpatch

Cleanups a good, but please put them in a patch of their own.

https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#separate-your-changes

   3) Separate your changes

   Separate each logical change into a separate patch.

Andrew