linux-kernel - [PATCH v7 0/2] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221127-snd-freeze-v7-0-127c582f1ca4@chromium.org>
Date:   Wed, 30 Nov 2022 17:29:19 +0100
From:   Ricardo Ribalda <ribalda@...omium.org>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Chromeos Kdump <chromeos-kdump@...gle.com>,
        Mark Brown <broonie@...nel.org>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Takashi Iwai <tiwai@...e.com>
Cc:     alsa-devel@...a-project.org, sound-open-firmware@...a-project.org,
        kexec@...ts.infradead.org, stable@...r.kernel.org,
        Ricardo Ribalda <ribalda@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: [PATCH v7 0/2] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

Since: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers in .shutdown")
we wait for all the workloads to be completed during shutdown. This was done to 
avoid a stall once the device is started again.

Unfortunately this has the side effect of stalling kexec(), if the userspace
is frozen. Let's handle that case.

To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Liam Girdwood <lgirdwood@...il.com>
To: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To: Bard Liao <yung-chuan.liao@...ux.intel.com>
To: Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>
To: Kai Vehmanen <kai.vehmanen@...ux.intel.com>
To: Daniel Baluta <daniel.baluta@....com>
To: Mark Brown <broonie@...nel.org>
To: Jaroslav Kysela <perex@...ex.cz>
To: Takashi Iwai <tiwai@...e.com>
To: Eric Biederman <ebiederm@...ssion.com>
To: Chromeos Kdump <chromeos-kdump@...gle.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: stable@...r.kernel.org
Cc: sound-open-firmware@...a-project.org
Cc: alsa-devel@...a-project.org
Cc: linux-kernel@...r.kernel.org
Cc: kexec@...ts.infradead.org
Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
---
Changes in v7:
- Fix commit message (Thanks Pierre-Louis).
- Link to v6: https://lore.kernel.org/r/20221127-snd-freeze-v6-0-3e90553f64a5@chromium.org

Changes in v6:
- Check if we are in kexec with the userspace frozen.
- Link to v5: https://lore.kernel.org/r/20221127-snd-freeze-v5-0-4ededeb08ba0@chromium.org

Changes in v5:
- Edit subject prefix.
- Link to v4: https://lore.kernel.org/r/20221127-snd-freeze-v4-0-51ca64b7f2ab@chromium.org

Changes in v4:
- Do not call snd_sof_machine_unregister from shutdown.
- Link to v3: https://lore.kernel.org/r/20221127-snd-freeze-v3-0-a2eda731ca14@chromium.org

Changes in v3:
- Wrap pm_freezing in a function.
- Link to v2: https://lore.kernel.org/r/20221127-snd-freeze-v2-0-d8a425ea9663@chromium.org

Changes in v2:
- Only use pm_freezing if CONFIG_FREEZER .
- Link to v1: https://lore.kernel.org/r/20221127-snd-freeze-v1-0-57461a366ec2@chromium.org

---
Ricardo Ribalda (2):
      kexec: Introduce kexec_with_frozen_processes
      ASoC: SOF: Fix deadlock when shutdown a frozen userspace

 include/linux/kexec.h | 3 +++
 kernel/kexec_core.c   | 5 +++++
 sound/soc/sof/core.c  | 4 +++-
 3 files changed, 11 insertions(+), 1 deletion(-)
---
base-commit: 4312098baf37ee17a8350725e6e0d0e8590252d4
change-id: 20221127-snd-freeze-1ee143228326

Best regards,
-- 
Ricardo Ribalda <ribalda@...omium.org>