[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3f51282076fb3e209aa4cae7bc0a4c46@walle.cc>
Date: Thu, 01 Dec 2022 23:12:39 +0100
From: Michael Walle <michael@...le.cc>
To: Nathan Barrett-Morrison <nathan.morrison@...esys.com>
Cc: greg.malysa@...esys.com,
Tudor Ambarus <tudor.ambarus@...rochip.com>,
Pratyush Yadav <pratyush@...nel.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] mtd: spi-nor: Add support for IS25LX256 operating
in 1S-8S-8S octal read mode
Am 2022-12-01 22:27, schrieb Nathan Barrett-Morrison:
> This adds the IS25LX256 chip into the ISSI flash_info parts table
>
> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@...esys.com>
> ---
> drivers/mtd/spi-nor/issi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> index 89a66a19d754..98cc5e1d9c18 100644
> --- a/drivers/mtd/spi-nor/issi.c
> +++ b/drivers/mtd/spi-nor/issi.c
> @@ -74,6 +74,9 @@ static const struct flash_info issi_nor_parts[] = {
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> .fixups = &is25lp256_fixups },
> + { "is25lx256", INFO(0x9d5a19, 0, 128 * 1024, 256)
Please use INFO(0x9d5a19, 0, 0, 0)
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_4B_OPCODES |
> + SPI_NOR_OCTAL_READ_1_8_8) },
Neither of these flags should be needed. As mentioned before,
you'd need a fixups for the missing 1-1-8 and 1-8-8 fast read ops.
-michael
Powered by blists - more mailing lists