linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable PCIe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Dec 2022 17:35:05 -0500
From:   Brian Masney <bmasney@...hat.com>
To:     Bjorn Andersson <andersson@...nel.org>
Cc:     krzysztof.kozlowski+dt@...aro.org, agross@...nel.org,
        konrad.dybcio@...aro.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_shazhuss@...cinc.com,
        psodagud@...cinc.com, ahalaney@...hat.com, echanude@...hat.com
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable PCIe support

On Thu, Dec 01, 2022 at 04:30:12PM -0600, Bjorn Andersson wrote:
> On Thu, Dec 01, 2022 at 12:19:31PM -0500, Brian Masney wrote:
> > +		vreg_l11a: ldo11 {
> > +			regulator-name = "vreg_l11a";
> > +			regulator-min-microvolt = <880000>;
> > +			regulator-max-microvolt = <880000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > +			regulator-allow-set-load;
> 
> In order to specify regulator-allow-set-load you also need
> regulator-allowed-modes.
> 
> But if I read the implementation correction, we don't actually alter the
> load, so perhaps best to just omit this for now?

I can drop regulator-allow-set-load in v3. I almost left it off and
verified the other day that PCIe still works without it.

Brian