linux-kernel - Re: [PATCH] signal: Initialize the info in ksignal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166993814728.941514.14527504091820169396.b4-ty@chromium.org>
Date:   Thu,  1 Dec 2022 15:42:28 -0800
From:   Kees Cook <keescook@...omium.org>
To:     haifeng.xu@...pee.com, brauner@...nel.org
Cc:     Kees Cook <keescook@...omium.org>, elver@...gle.com,
        oleg@...hat.com, ebiederm@...ssion.com,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        peterz@...radead.org
Subject: Re: [PATCH] signal: Initialize the info in ksignal

On Mon, 28 Nov 2022 06:56:06 +0000, haifeng.xu wrote:
> When handing the SIGNAL_GROUP_EXIT flag, the info in ksignal isn't cleared.
> However, the info acquired by dequeue_synchronous_signal/dequeue_signal is
> initialized and can be safely used. Fortunately, the fatal signal process
> just uses the si_signo and doesn't use any other member. Even so, the
> initialization before use is more safer.
> 
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] signal: Initialize the info in ksignal
      https://git.kernel.org/kees/c/935d428bb528

-- 
Kees Cook