linux-kernel - Re: [PATCH] scsi: efct: Fix possible memleak in efct_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166986602281.2101055.16297897704954452228.b4-ty@oracle.com>
Date:   Thu,  1 Dec 2022 03:45:04 +0000
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org,
        Chen Zhongjin <chenzhongjin@...wei.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        jejb@...ux.ibm.com, christophe.jaillet@...adoo.fr, hare@...e.de,
        ram.vegesna@...adcom.com, dwagner@...e.de, james.smart@...adcom.com
Subject: Re: [PATCH] scsi: efct: Fix possible memleak in efct_device_init()

On Fri, 11 Nov 2022 15:40:46 +0800, Chen Zhongjin wrote:

> In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
> efct_scsi_tgt_driver_exit() is not called to release memory for
> efct_scsi_tgt_driver_init() and causes memleak:
> 
> unreferenced object 0xffff8881020ce000 (size 2048):
>   comm "modprobe", pid 465, jiffies 4294928222 (age 55.872s)
>   backtrace:
>     [<0000000021a1ef1b>] kmalloc_trace+0x27/0x110
>     [<000000004c3ed51c>] target_register_template+0x4fd/0x7b0 [target_core_mod]
>     [<00000000f3393296>] efct_scsi_tgt_driver_init+0x18/0x50 [efct]
>     [<00000000115de533>] 0xffffffffc0d90011
>     [<00000000d608f646>] do_one_initcall+0xd0/0x4e0
>     [<0000000067828cf1>] do_init_module+0x1cc/0x6a0
>     ...
> 
> [...]

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: efct: Fix possible memleak in efct_device_init()
      https://git.kernel.org/mkp/scsi/c/bb0cd225dd37

-- 
Martin K. Petersen	Oracle Linux Engineering