linux-kernel - Re: [PATCH v7 1/2] kexec: Introduce kexec_with_frozen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212011317.FCdljFpm-lkp@intel.com>
Date:   Thu, 1 Dec 2022 13:24:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ricardo Ribalda <ribalda@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Chromeos Kdump <chromeos-kdump@...gle.com>,
        Mark Brown <broonie@...nel.org>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Takashi Iwai <tiwai@...e.com>
Cc:     oe-kbuild-all@...ts.linux.dev, alsa-devel@...a-project.org,
        sound-open-firmware@...a-project.org, kexec@...ts.infradead.org,
        stable@...r.kernel.org, Ricardo Ribalda <ribalda@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/2] kexec: Introduce kexec_with_frozen_processes

Hi Ricardo,

I love your patch! Yet something to improve:

[auto build test ERROR on 4312098baf37ee17a8350725e6e0d0e8590252d4]

url:    https://github.com/intel-lab-lkp/linux/commits/Ricardo-Ribalda/ASoC-SOF-Fix-deadlock-when-shutdown-a-frozen-userspace/20221201-003214
base:   4312098baf37ee17a8350725e6e0d0e8590252d4
patch link:    https://lore.kernel.org/r/20221127-snd-freeze-v7-1-127c582f1ca4%40chromium.org
patch subject: [PATCH v7 1/2] kexec: Introduce kexec_with_frozen_processes
config: ia64-randconfig-r022-20221128
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ddb7195380bb431ff9f4505d5fcfbef756b80a3a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ricardo-Ribalda/ASoC-SOF-Fix-deadlock-when-shutdown-a-frozen-userspace/20221201-003214
        git checkout ddb7195380bb431ff9f4505d5fcfbef756b80a3a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/kexec_core.c: In function 'kexec_with_frozen_processes':
>> kernel/kexec_core.c:59:37: error: 'pm_freezing' undeclared (first use in this function); did you mean 'freezing'?
      59 |         return kexec_in_progress && pm_freezing;
         |                                     ^~~~~~~~~~~
         |                                     freezing
   kernel/kexec_core.c:59:37: note: each undeclared identifier is reported only once for each function it appears in
   kernel/kexec_core.c:60:1: error: control reaches end of non-void function [-Werror=return-type]
      60 | }
         | ^
   cc1: some warnings being treated as errors


vim +59 kernel/kexec_core.c

    56	
    57	bool kexec_with_frozen_processes(void)
    58	{
  > 59		return kexec_in_progress && pm_freezing;
    60	}
    61	EXPORT_SYMBOL(kexec_with_frozen_processes);
    62	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (126328 bytes)