linux-kernel - Re: [PATCH 0/3] staging: greybus: Cleanups in loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4hU8oC7H5h6G2ZI@hovoldconsulting.com>
Date:   Thu, 1 Dec 2022 08:17:06 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Jack Schofield <schofija@...gonstate.edu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] staging: greybus: Cleanups in loopback_test

On Wed, Nov 30, 2022 at 09:38:49PM -0800, Jack Schofield wrote:
> Correct issues found by checkpatch.
> 
> Jack Schofield (3):
>   staging: greybus: loopback_test: Add blank line after declaration.

Nit: no need for a full stop in the commit summary.

>   staging: greybus: loopback_test: Remove void function return statement
>   staging: greybus: loopback_test: Remove extra blank lines
> 
>  drivers/staging/greybus/tools/loopback_test.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)

Other than that, all of these look good to me:

Reviewed-by: Johan Hovold <johan@...nel.org>

Johan