[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ba14a46f-477f-70af-761d-696fe8a4f41c@collabora.com>
Date: Thu, 1 Dec 2022 10:07:28 +0100
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>
Cc: Project_Global_Chrome_Upstream_Group@...iatek.com,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
Chen-Yu Tsai <wenst@...omium.org>
Subject: Re: [PATCH] arm64: dts: mt8192: Add adsp power domain controller
Il 01/12/22 08:33, Allen-KH Cheng ha scritto:
> Add adsp power domain controller node for mt8192 SoC.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> ---
> Ref: https://lore.kernel.org/all/2ec80bd8-dfef-d2e6-eb41-6e6088043e33@collabora.com/
> [Allen-KH Cheng <allen-kh.cheng@...iatek.com>]
> ---
> ---
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 8 ++++++++
> include/dt-bindings/power/mt8192-power.h | 1 +
> 2 files changed, 9 insertions(+)
>
Allen, thanks for this one, but it's incomplete...
First of all, you must add the power domain on the driver itself, specifically,
in drivers/soc/mediatek/mt8192-pm-domains.h - otherwise this change will have no
effect!
...Then, as Chen-Yu said, you should also add the power domain to the scp_adsp
clock node as that's solving the lockup issue...
.......and last, but not least: we need a Fixes tag to backport this fix, here
and on the commit that adds the missing power domain in the driver.
Thanks,
Angelo
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 424fc89cc6f7..e71afba871fc 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -514,6 +514,14 @@
> };
> };
> };
> +
> + power-domain@...192_POWER_DOMAIN_ADSP {
> + reg = <MT8192_POWER_DOMAIN_ADSP>;
> + clocks = <&topckgen CLK_TOP_ADSP_SEL>;
> + clock-names = "adsp";
> + mediatek,infracfg = <&infracfg>;
> + #power-domain-cells = <0>;
> + };
> };
> };
>
> diff --git a/include/dt-bindings/power/mt8192-power.h b/include/dt-bindings/power/mt8192-power.h
> index 4eaa53d7270a..63e81cd0d06d 100644
> --- a/include/dt-bindings/power/mt8192-power.h
> +++ b/include/dt-bindings/power/mt8192-power.h
> @@ -28,5 +28,6 @@
> #define MT8192_POWER_DOMAIN_CAM_RAWA 18
> #define MT8192_POWER_DOMAIN_CAM_RAWB 19
> #define MT8192_POWER_DOMAIN_CAM_RAWC 20
> +#define MT8192_POWER_DOMAIN_ADSP 21
>
> #endif /* _DT_BINDINGS_POWER_MT8192_POWER_H */
>
Powered by blists - more mailing lists