lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221201091722.p7fth4vkbbpq2zx4@sgarzare-redhat> Date: Thu, 1 Dec 2022 10:17:22 +0100 From: Stefano Garzarella <sgarzare@...hat.com> To: Arseniy Krasnov <AVKrasnov@...rdevices.ru> Cc: "David S. Miller" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "kys@...rosoft.com" <kys@...rosoft.com>, "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, Bryan Tan <bryantan@...are.com>, Vishnu Dasa <vdasa@...are.com>, Krasnov Arseniy <oxffffaa@...il.com>, Bobby Eshleman <bobby.eshleman@...il.com>, Bobby Eshleman <bobby.eshleman@...edance.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, kernel <kernel@...rdevices.ru> Subject: Re: [RFC PATCH v2 1/6] vsock: return errors other than -ENOMEM to socket On Fri, Nov 25, 2022 at 05:03:06PM +0000, Arseniy Krasnov wrote: >From: Bobby Eshleman <bobby.eshleman@...edance.com> > >This removes behaviour, where error code returned from any >transport was always switched to ENOMEM. > >Signed-off-by: Bobby Eshleman <bobby.eshleman@...edance.com> >Signed-off-by: Arseniy Krasnov <AVKrasnov@...rdevices.ru> >--- > net/vmw_vsock/af_vsock.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch LGTM, but I would move after the 2 patches that change vmci and hyperv transports. First we should fix the transports by returning the error we think is right, and then expose it to the user. Thanks, Stefano > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 884eca7f6743..61ddab664c33 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1862,8 +1862,9 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg, > written = transport->stream_enqueue(vsk, > msg, len - total_written); > } >+ > if (written < 0) { >- err = -ENOMEM; >+ err = written; > goto out_err; > } > >-- >2.25.1
Powered by blists - more mailing lists