[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2886dd64-435d-1cdb-168d-5851c37dc538@linaro.org>
Date: Thu, 1 Dec 2022 10:27:26 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: JiaJie Ho <jiajie.ho@...rfivetech.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S . Miller" <davem@...emloft.net>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto
driver
On 01/12/2022 10:01, JiaJie Ho wrote:
>>> +
>>> + enable-side-channel-mitigation:
>>> + description: Enable side-channel-mitigation feature for AES module.
>>> + Enabling this feature will affect the speed performance of
>>> + crypto engine.
>>> + type: boolean
>>
>> Why exactly this is a hardware (DT) property, not runtime?
>>
>
> This is a hardware setting provided in StarFive crypto engine only.
> The crypto API doesn't control this setting during runtime and leaving this always on will impact speed performance.
> So, I added this property to allow user to control this in dtb.
Devicetree should not describe policies, so without justification it
does not look like hardware property. Drop.
Best regards,
Krzysztof
Powered by blists - more mailing lists