lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Nov 2022 16:52:11 -0800 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Changbin Du <changbin.du@...il.com> Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Quentin Monnet <quentin@...valent.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Shuah Khan <shuah@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, bpf@...r.kernel.org, linux-kernel@...r.kernel.org, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Namhyung Kim <namhyung@...nel.org>, Mykola Lysenko <mykolal@...com>, linux-perf-users@...r.kernel.org, linux-kselftest@...r.kernel.org Subject: Re: [PATCH v2 2/2] bpf: makefiles: do not generate empty vmlinux.h On Tue, Nov 29, 2022 at 5:42 AM Changbin Du <changbin.du@...il.com> wrote: > > Remove the empty vmlinux.h if bpftool failed to dump btf info. > The emptry vmlinux.h can hide real error when reading output typo: empty > of make. > > This is done by adding .DELETE_ON_ERROR special target in related > makefiles. > > Signed-off-by: Changbin Du <changbin.du@...il.com> > --- > tools/bpf/bpftool/Makefile | 3 +++ > tools/perf/Makefile.perf | 2 ++ > tools/testing/selftests/bpf/Makefile | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile > index 4a95c017ad4c..f6b1e65085db 100644 > --- a/tools/bpf/bpftool/Makefile > +++ b/tools/bpf/bpftool/Makefile > @@ -265,3 +265,6 @@ FORCE: > .PHONY: all FORCE bootstrap clean install-bin install uninstall > .PHONY: doc doc-clean doc-install doc-uninstall > .DEFAULT_GOAL := all > + > +# Delete partially updated (corrupted) files on error > +.DELETE_ON_ERROR: > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index a432e59afc42..265254fc641a 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -1149,3 +1149,5 @@ FORCE: > .PHONY: libtraceevent_plugins archheaders > > endif # force_fixdep > + > +.DELETE_ON_ERROR: please split out perf changes, they should go through perf tree > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index e6cf21fad69f..f41c4b011221 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -617,3 +617,6 @@ EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(SCRATCH_DIR) $(HOST_SCRATCH_DIR) \ > liburandom_read.so) > > .PHONY: docs docs-clean > + > +# Delete partially updated (corrupted) files on error > +.DELETE_ON_ERROR: > -- > 2.37.2 >
Powered by blists - more mailing lists