linux-kernel - Re: [PATCH] habanalabs: fix double assignment in MMU V1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf11cqNHZhAR0b8iKnGeT_XVy5Oa2KHjNo7ROVF2-MjYZfA@mail.gmail.com>
Date:   Thu, 1 Dec 2022 12:31:18 +0200
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Marco Pagani <marpagan@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] habanalabs: fix double assignment in MMU V1

On Tue, Nov 29, 2022 at 1:52 PM Marco Pagani <marpagan@...hat.com> wrote:
>
> Removing double assignment of the hop2_pte_addr
> variable in dram_default_mapping_fini().
>
> Dead store reported by clang-analyzer.
>
> Signed-off-by: Marco Pagani <marpagan@...hat.com>
> ---
>  drivers/misc/habanalabs/common/mmu/mmu_v1.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> index 8a40de4a4761..d925dc4dd097 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> @@ -344,7 +344,6 @@ static void dram_default_mapping_fini(struct hl_ctx *ctx)
>                 }
>         }
>
> -       hop2_pte_addr = hop2_addr;
>         hop2_pte_addr = hop2_addr;
>         for (i = 0 ; i < num_of_hop3 ; i++) {
>                 clear_pte(ctx, hop2_pte_addr);
> --
> 2.38.1
>

Reviewed-by: Oded Gabbay <ogabbay@...nel.org>
Applied to -next.
Thanks,
Oded