[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87a647s8zg.fsf@mpe.ellerman.id.au>
Date: Thu, 01 Dec 2022 21:40:03 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Arınç ÜNAL <arinc.unal@...nc9.com>,
Pali Rohár <pali@...nel.org>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Arınç ÜNAL <arinc.unal@...nc9.com> writes:
> This is not used by the DSA dt-binding, so remove it from all devicetrees.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
> arch/powerpc/boot/dts/turris1x.dts | 2 --
> 1 file changed, 2 deletions(-)
Adding Pali to Cc.
These were only recently updated in commit:
8bf056f57f1d ("powerpc: dts: turris1x.dts: Fix labels in DSA cpu port nodes")
Which said:
DSA cpu port node has to be marked with "cpu" label.
But if the binding doesn't use them then I'm confused why they needed to
be updated.
cheers
> diff --git a/arch/powerpc/boot/dts/turris1x.dts b/arch/powerpc/boot/dts/turris1x.dts
> index 045af668e928..3841c8d96d00 100644
> --- a/arch/powerpc/boot/dts/turris1x.dts
> +++ b/arch/powerpc/boot/dts/turris1x.dts
> @@ -147,7 +147,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - label = "cpu";
> ethernet = <&enet1>;
> phy-mode = "rgmii-id";
>
> @@ -184,7 +183,6 @@ port@5 {
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&enet0>;
> phy-mode = "rgmii-id";
>
> --
> 2.34.1
Powered by blists - more mailing lists