linux-kernel - Re: [PATCH v2] clocksource: ingenic-ost: define pm functions properly in platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mt87s827.ffs@tglx>
Date:   Thu, 01 Dec 2022 12:00:00 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Maarten ter Huurne <maarten@...ewalker.org>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH v2] clocksource: ingenic-ost: define pm functions
 properly in platform_driver struct

Lukas!

On Wed, Nov 23 2022 at 09:31, Lukas Bulwahn wrote:
> Commit ca7b72b5a5f2 ("clocksource: Add driver for the Ingenic JZ47xx OST")
> adds the struct platform_driver ingenic_ost_driver, with the definition of
> pm functions under the non-existing config PM_SUSPEND, which means the
> intended pm functions were never actually included in any build.
>
> As the only callbacks are .suspend_noirq and .resume_noirq, we can assume
> that it is intended to be CONFIG_PM_SLEEP.
>
> Since commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate
> old ones"), the default pattern for platform_driver definitions
> conditional for CONFIG_PM_SLEEP is to use pm_sleep_ptr().
>
> As __maybe_unused annotations on the dev_pm_ops structure and its callbacks
> are not needed anymore, remove these as well.
>
> Suggested-by: Paul Cercueil <paul@...pouillou.net>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

just a minor nit. The subsystem prefix should be:

     clocksource/drivers/ingenic-ost:

git log --one-line $FILE is usually a good hint for the subsystem
specific prefix choice.

Fixed it up while applying.

Thanks,

        tglx