linux-kernel - Re: Re：Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs, show temperature of cpu.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Dec 2022 11:41:07 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     王洪辉 <honghui.wang@...s.com.cn>
Cc:     Cristian Marussi <cristian.marussi@....com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: Re：Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs, show temperature of cpu.

On Thu, Dec 01, 2022 at 06:41:46PM +0800, 王洪辉 wrote:
> In DTS of FT2000/4 passed from uboot. Add the DTS file to kernel?
>

No, I was referring to the binding not the DTS file like
Documentation/devicetree/bindings/firmware/arm,scpi.yaml

> Of course, it's also a good way to modify DTS file built in uboot.
>

You need to add the binding to make use of this new compatible in the driver.
And when you add, the first question I have is why you need new compatible
or why you can't use the generic one. If you have valid reasons for that,
then we can add the driver change along with the binding. Please split the
binding that you are about to add and the SCPI driver changes separate from
the mailbox driver changes in this patch.

-- 
Regards,
Sudeep