[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9fdc4e0eee7ead18c119b6bc3e93f7f73d2980cd.camel@redhat.com>
Date: Thu, 01 Dec 2022 12:40:51 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Roger Quadros <rogerq@...nel.org>, davem@...emloft.net,
maciej.fijalkowski@...el.com, kuba@...nel.org
Cc: andrew@...n.ch, edumazet@...gle.com, vigneshr@...com,
linux-omap@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 net-next 4/6] net: ethernet: ti: am65-cpsw: Add
suspend/resume support
On Tue, 2022-11-29 at 15:34 +0200, Roger Quadros wrote:
> @@ -555,11 +556,26 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev)
> struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
> int ret, i;
> + u32 reg;
>
> ret = pm_runtime_resume_and_get(common->dev);
> if (ret < 0)
> return ret;
>
> + /* Idle MAC port */
> + cpsw_sl_ctl_set(port->slave.mac_sl, CPSW_SL_CTL_CMD_IDLE);
> + cpsw_sl_wait_for_idle(port->slave.mac_sl, 100);
> + cpsw_sl_ctl_reset(port->slave.mac_sl);
> +
> + /* soft reset MAC */
> + cpsw_sl_reg_write(port->slave.mac_sl, CPSW_SL_SOFT_RESET, 1);
> + mdelay(1);
> + reg = cpsw_sl_reg_read(port->slave.mac_sl, CPSW_SL_SOFT_RESET);
> + if (reg) {
> + dev_err(common->dev, "soft RESET didn't complete\n");
I *think* Andrew was asking for dev_dbg() here, but let's see what he
has to say :)
Cheers,
Paolo
Powered by blists - more mailing lists