| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y4iiOBzus5v5aOIP@corigine.com>
Date: Thu, 1 Dec 2022 13:46:48 +0100
From: Simon Horman <simon.horman@...igine.com>
To: wangchuanlei <wangchuanlei@...pur.com>
Cc: kuba@...nel.org, dev@...nvswitch.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, edumazet@...gle.com,
alexandr.lobakin@...el.com, pabeni@...hat.com, davem@...emloft.net
Subject: Re: [ovs-dev] [PATCH] [PATCH v6 net-next] net: openvswitch: Add
support to count upcall packets
Hi,
On Thu, Dec 01, 2022 at 03:46:01AM -0500, wangchuanlei wrote:
> Hi, Jakub,
>
> Thank you for review, the comments below is a little confusing, can you
> give a explanation?
>
> Best regards!
> wangchuanlei
>
> --------------------------------------------------------
> On Wed, 30 Nov 2022 04:15:59 -0500 wangchuanlei wrote:
> > +/**
> > + * ovs_vport_get_upcall_stats - retrieve upcall stats
> > + *
> > + * @vport: vport from which to retrieve the stats
> > + * @ovs_vport_upcall_stats: location to store stats
>
> s/ovs_vport_upcall_//
I believe Jakub is asking for "ovs_vport_upcall_" to be removed.
Or, in other words, to refer to the parameter as "stats",
(which matches the name in the function signature below).
>
> > + *
> > + * Retrieves upcall stats for the given device.
> > + *
> > + * Must be called with ovs_mutex or rcu_read_lock.
> > + */
> > +void ovs_vport_get_upcall_stats(struct vport *vport, struct ovs_vport_upcall_stats *stats)
>
> _______________________________________________
> dev mailing list
> dev@...nvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Powered by blists - more mailing lists