linux-kernel - Re: [EXT] Re: [PATCH] net: atlantic: fix check for invalid ethernet addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4iyNRhkFmG/Avco@x1>
Date:   Thu, 1 Dec 2022 08:55:01 -0500
From:   Brian Masney <bmasney@...hat.com>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     Andrew Lunn <andrew@...n.ch>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        cth451@...il.com
Subject: Re: [EXT] Re: [PATCH] net: atlantic: fix check for invalid ethernet
 addresses

On Thu, Dec 01, 2022 at 09:07:49AM +0100, Igor Russkikh wrote:
> 
> >> That won't work for this board since that function only checks that the
> >> MAC "is not 00:00:00:00:00:00, is not a multicast address, and is not
> >> FF:FF:FF:FF:FF:FF." The MAC address that we get on all of our boards is
> >> 00:17:b6:00:00:00.
> > 
> > Which is a valid MAC address. So i don't see why the kernel should
> > reject it and use a random one.
> > 
> > Maybe you should talk to Marvell about how you can program the
> > e-fuses. You can then use MAC addresses from A8-97-DC etc.
> 
> Hi Brian,
> 
> I do completely agree with Andrew. Thats not a fix to be made in
> linux kernel.
> 
> The boards you get have zero efuse. You should work with Qualcomm on
> how to update mac addresses of your boards.

OK, I'll work to track down someone within Qualcomm that can help us
program the MAC address into the boards that we have. In the mean time,
we'll go with the systemd unit approach to set a MAC address.

Thank you all!

Brian