linux-kernel - Re: [PATCH] kselftests: cgroup: update kmem test precision tolerance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Dec 2022 01:48:44 +0800
From:   Yujie Liu <yujie.liu@...el.com>
To:     Michal Hocko <mhocko@...e.com>
CC:     Shakeel Butt <shakeelb@...gle.com>, <oe-lkp@...ts.linux.dev>,
        <lkp@...el.com>, Andrew Morton <akpm@...ux-foundation.org>,
        kernel test robot <oliver.sang@...el.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Feng Tang <feng.tang@...el.com>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Muchun Song <songmuchun@...edance.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "Johannes Weiner" <hannes@...xchg.org>,
        Michal Koutný <mkoutny@...e.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kselftests: cgroup: update kmem test precision tolerance

On Fri, Dec 02, 2022 at 09:50:26AM +0100, Michal Hocko wrote:
> OK, so this is a full patch to fix this
> --- 
> From 7f338ed952ba4a100822004bc8399bf720b42899 Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@...e.com>
> Date: Fri, 2 Dec 2022 09:45:29 +0100
> Subject: [PATCH] kselftests: cgroup: update kmem test precision tolerance
> 
> 1813e51eece0 ("memcg: increase MEMCG_CHARGE_BATCH to 64") has changed
> the batch size while this test case has been left behind. This has led
> to a test failure reported by test bot:
> not ok 2 selftests: cgroup: test_kmem # exit=1
> 
> Update the tolerance for the pcp charges to reflect the
> MEMCG_CHARGE_BATCH change to fix this.
> 
> Reported-by: kernel test robot <yujie.liu@...el.com>
> Link: https://lore.kernel.org/oe-lkp/202212010958.c1053bd3-yujie.liu@intel.com
> Signed-off-by: Michal Hocko <mhocko@...e.com>

The failure is gone after applying this patch. Thanks.

Tested-by: Yujie Liu <yujie.liu@...el.com>

=========================================================================================
compiler/group/kconfig/rootfs/tbox_group/testcase:
  gcc-11/cgroup/x86_64-rhel-8.3-kselftests/debian-12-x86_64-20220629.cgz/lkp-icl-2sp5/kernel-selftests

commit:
  1813e51eece0a ("memcg: increase MEMCG_CHARGE_BATCH to 64")
  8046f9500f4b7 ("kselftests: cgroup: update kmem test precision tolerance")

  1813e51eece0a                8046f9500f4b7
---------------- ------------- -------------
       fail:runs  %reproduction    fail:runs
           |             |             |
          3:3         -100%            :5     kernel-selftests.cgroup.test_kmem.test_kmem_memcg_deletion.fail

> ---
>  tools/testing/selftests/cgroup/test_kmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c
> index 22b31ebb3513..1d073e28254b 100644
> --- a/tools/testing/selftests/cgroup/test_kmem.c
> +++ b/tools/testing/selftests/cgroup/test_kmem.c
> @@ -24,7 +24,7 @@
>   * the maximum discrepancy between charge and vmstat entries is number
>   * of cpus multiplied by 32 pages.
>   */
> -#define MAX_VMSTAT_ERROR (4096 * 32 * get_nprocs())
> +#define MAX_VMSTAT_ERROR (4096 * 64 * get_nprocs())
>  
>  
>  static int alloc_dcache(const char *cgroup, void *arg)
> -- 
> 2.30.2
> 
> -- 
> Michal Hocko
> SUSE Labs