linux-kernel - Re: [PATCH] ACPI: battery: Call power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gY5UrD9tmVUWQEKdCmGK+W-4XiZ_EgY9Dd7jEuY_zmww@mail.gmail.com>
Date:   Fri, 2 Dec 2022 20:31:43 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Armin Wolf <W_Armin@....de>
Cc:     rafael@...nel.org, hdegoede@...hat.com, lenb@...nel.org,
        markgross@...nel.org, linux-acpi@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: battery: Call power_supply_changed() when adding hooks

On Wed, Nov 30, 2022 at 7:41 PM Armin Wolf <W_Armin@....de> wrote:
>
> If a battery hook is added to a battery, userspace software
> is not informed that the available properties of the battery
> might have changed. This for example causes upower to react
> slowly if a new battery hook is added during runtime.
>
> Fix this by calling power_supply_changed() if a battery hook
> was successfully added/removed.
>
> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <W_Armin@....de>
> ---
>  drivers/acpi/battery.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 9482b0b6eadc..bf99053e5021 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -696,7 +696,8 @@ static void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock)
>         if (lock)
>                 mutex_lock(&hook_mutex);
>         list_for_each_entry(battery, &acpi_battery_list, list) {
> -               hook->remove_battery(battery->bat, hook);
> +               if (!hook->remove_battery(battery->bat, hook))
> +                       power_supply_changed(battery->bat);
>         }
>         list_del(&hook->list);
>         if (lock)
> @@ -735,6 +736,8 @@ void battery_hook_register(struct acpi_battery_hook *hook)
>                         __battery_hook_unregister(hook, 0);
>                         goto end;
>                 }
> +
> +               power_supply_changed(battery->bat);
>         }
>         pr_info("new extension: %s\n", hook->name);
>  end:
> --

Applied as 6.2 material, but I had to rebase it, so please check the
result in my bleeding-edge branch.

Thanks!