linux-kernel - Re: [PATCH bpf-next] bpf, docs: BPF Iterator Document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Dec 2022 12:01:09 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Sreevani Sreejith <ssreevani@...a.com>
Cc:     bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, psreep@...il.com,
        David Vernet <void@...ifault.com>,
        Yonghong Song <yhs@...a.com>, mykolal@...a.com
Subject: Re: [PATCH bpf-next] bpf, docs: BPF Iterator Document

On Fri, Dec 2, 2022 at 9:42 AM Sreevani Sreejith <ssreevani@...a.com> wrote:
>
> From: Sreevani Sreejith <psreep@...il.com>
>
> Document that describes how BPF iterators work, how to use iterators,
> and how to pass parameters in BPF iterators.
>
> Acked-by: David Vernet <void@...ifault.com>
> Signed-off-by: Sreevani Sreejith <psreep@...il.com>
> ---
>  Documentation/bpf/bpf_iterators.rst           |  487 +
>  .../bpf/images/bpf_iterator_flow.svg          | 9589 +++++++++++++++++

The graph looks nice, but it's huge.
Almost 1Mbyte.
The largest .svg file in the kernel tree is 200k.

Also it doesn't seem to add too much additional info
vs what's described in the text.
I suggest to drop .svg and stick to text only.
Or draw a text only diagram, but it doesn't look necessary in this case.