linux-kernel - Re: (subset) [PATCH 1/3] clk: qcom: lpass-sc7280: Fix pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri,  2 Dec 2022 14:58:44 -0600
From:   Bjorn Andersson <andersson@...nel.org>
To:     swboyd@...omium.org, dianders@...omium.org
Cc:     dmitry.baryshkov@...aro.org, konrad.dybcio@...ainline.org,
        mka@...omium.org, sboyd@...nel.org, quic_tdas@...cinc.com,
        linux-arm-msm@...r.kernel.org, tdas@...eaurora.org,
        judyhsiao@...omium.org, agross@...nel.org, mturquette@...libre.com,
        linux-kernel@...r.kernel.org, quic_srivasam@...cinc.com,
        linux-clk@...r.kernel.org
Subject: Re: (subset) [PATCH 1/3] clk: qcom: lpass-sc7280: Fix pm_runtime usage

On Fri, 4 Nov 2022 06:56:28 -0700, Douglas Anderson wrote:
> The pm_runtime usage in lpass-sc7280 was broken in quite a few
> ways. Specifically:
> 
> 1. At the end of probe it called "put" twice. This is a no-no and will
>    end us up with a negative usage count. Even worse than calling
>    "put" twice, it never called "get" once. Thus after bootup it could
>    be seen that the runtime usage of the devices managed by this
>    driver was -2.
> 2. In some error cases it manually called pm_runtime_disable() even
>    though it had previously used devm_add_action_or_reset() to set
>    this up to be called automatically. This meant that in these error
>    cases we'd double-call pm_runtime_disable().
> 3. It forgot to call undo pm_runtime_use_autosuspend(), which can
>    sometimes have subtle problems (and the docs specifically mention
>    that you need to undo this function).
> 
> [...]

Applied, thanks!

[1/3] clk: qcom: lpass-sc7280: Fix pm_runtime usage
      commit: d470be3c4f30b4666e43eef6bab80f543563cdb0
[2/3] clk: qcom: lpass-sc7180: Fix pm_runtime usage
      commit: ff1ccf59eaffd192efe21f7de9fb0c130faf1b1b
[3/3] clk: qcom: lpass-sc7180: Avoid an extra "struct dev_pm_ops"
      commit: e3ad6c3f21ddb89e4b71361be8318da57dbe3597

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>