linux-kernel - Re: [PATCH] hfsplus: Add module parameter to enable force writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4pnuBnoHvIS8UB6@casper.infradead.org>
Date:   Fri, 2 Dec 2022 21:01:44 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Aditya Garg <gargaditya08@...e.com>,
        "ira.weiny@...el.com" <ira.weiny@...el.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "bvanassche@....org" <bvanassche@....org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "songmuchun@...edance.com" <songmuchun@...edance.com>,
        "slava@...eyko.com" <slava@...eyko.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] hfsplus: Add module parameter to enable force writes

On Fri, Dec 02, 2022 at 12:53:44PM -0800, Andrew Morton wrote:
> > +		if (force_journaled_rw) {
> > +			pr_warn("write access to a journaled filesystem is not supported, but has been force enabled.\n");
> > +		} else {
> > +			pr_warn("write access to a journaled filesystem is not supported, use the force option at your own risk, mounting read-only.\n");
> > +			sb->s_flags |= SB_RDONLY;
> > +		}
> 
> All these super long lines are an eyesore.  How about
> 
> 			pr_warn("write access to a journaled filesystem is "
> 				"not supported, but has been force enabled.\n");

Linus has asked us to not do that because it makes it hard to grep.